Remove default instance#916
Merged
Merged
Conversation
It’s not very interesting and breaks the definition of “instance” when we want to see the db name when no instance name is defined.
tylerbenson
added
type: bug
labbati
approved these changes
Jul 16, 2019
Member
labbati
left a comment
labbati
left a comment
There was a problem hiding this comment.
Approving this PR as in line with what seems to be requirement for the task.
There is one thing that is not clear to me from a usability standpoint, though.
If the feature 'split by domain' is enabled I would expect that we provide in the service name an indication of the DB. Based on what I see here we will put,:
- if the default instance
MSSQLSERVERis used then we are usingdb_name - otherwise we are using
INSTANCE_NAME
Is this the expected behavior?
Contributor
Author
|
Some databases only have instance and some only have db name... some have both. I felt like it was most "in the spirit" of the config setting to have it like this. The goal being having a more interesting service name. For this reason I decided to include "db name" also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It’s not very interesting and breaks the definition of “instance” when we want to see the db name when no instance name is defined.